Comments on: Code Review

By: Patrick Peralta

Patrick Peralta — Thu, 23 Apr 2009 10:45:37 +0000

We don’t use Crucible, but as huge Atlassian fanbois, we should consider taking a look, especially for remote code reviews. For the most part it is done peer to peer, but sometimes for new developers or for large submissions, we’ll throw it up on a projector in a conference room.

The coding style is a dialect of Whitesmiths (http://en.wikipedia.org/wiki/Indent_style). It took some getting used to from the K&R variant that most Java developers use, but I’ve actually grown quite fond of it.

The Hungarian-esque convention threw me off a bit too but I’ve grown to appreciate it as well. Although Java is a strongly typed language, you don’t always have the type declaration sitting in front of you, so it’s nice to be able to distinguish at a glance the variable type (and whether it is a member or local variable.)

We use Intellij IDEA, so changing the name of a variable is easier than changing the font on a Word doc.

By: Olaf Heimburger

Olaf Heimburger — Thu, 23 Apr 2009 05:08:11 +0000

That’s what refactoring is for. Improve the code but keep the functionality.
Anyway, your project should consider a decent Java Coding Convention. Like all strongly typed languages, Java doesn’t need the C-like Hungarian Notation in every variable name. Just ask yourself, what will happen if you have to change the type of the variable? Answer: You have to change all your dependent code. I’m just to lazy such stuff…

Cheers,
–olaf

By: Matt Trefethen

Matt Trefethen — Thu, 23 Apr 2009 00:21:04 +0000

It is much cleaner to read. Is the opening bracket on a separate line used standard for that purpose as well?

Is peer review facilitated by a tool like Crucible or are they done using meetings and process?